Skip to content

countDistinct overloads on GroupBy#1875

Merged
Allex-Nik merged 10 commits into
masterfrom
count-distinct-on-group-by
Jun 9, 2026
Merged

countDistinct overloads on GroupBy#1875
Allex-Nik merged 10 commits into
masterfrom
count-distinct-on-group-by

Conversation

@Allex-Nik

Copy link
Copy Markdown
Collaborator

Fixes #533.

The countDistinct function is currently defined only on DataFrame. In this PR, I add two countDistinct aggregations on GroupBy:

  • without a columns selector (all columns are considered)
  • with a columns selector.

KDocs and website docs are adjusted accordingly.

@Allex-Nik Allex-Nik requested review from Jolanrensen and zaleslaw May 27, 2026 15:06
Comment thread docs/StardustDocs/topics/groupBy.md
Comment thread core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/api/countDistinct.kt Outdated
@Jolanrensen

Copy link
Copy Markdown
Collaborator

good job! :D

@Allex-Nik Allex-Nik force-pushed the count-distinct-on-group-by branch 2 times, most recently from 43c51cf to d35b864 Compare June 3, 2026 12:42
@Allex-Nik Allex-Nik requested a review from Jolanrensen June 8, 2026 15:51
@Allex-Nik Allex-Nik force-pushed the count-distinct-on-group-by branch from a2ef8bb to 400ad0a Compare June 9, 2026 15:15
@Jolanrensen Jolanrensen self-requested a review June 9, 2026 16:02
@Allex-Nik Allex-Nik merged commit b5026aa into master Jun 9, 2026
5 checks passed
@Allex-Nik Allex-Nik deleted the count-distinct-on-group-by branch June 9, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Define and add countDistinct aggregation for GroupBy

2 participants